Plotting improvements #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can now pass Axes into plotting functions, can be used when the user wishes to make use of subplots etc. - Operations converted to make better use of NumPy - Better error reporting from plotting functions - Plotting tests greatly expanded, now produces example plots
Codecov Report
@@ Coverage Diff @@
## develop #55 +/- ##
===========================================
+ Coverage 96.07% 96.34% +0.26%
===========================================
Files 7 7
Lines 204 219 +15
===========================================
+ Hits 196 211 +15
Misses 8 8
Continue to review full report at Codecov.
|
incorrect quantity testing for scatter_tokamak_source was shadowed by the equivalent test for plot_tokamak_source_3D
RemDelaporteMathurin
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded TokamakSource plotting functions and expanded tests