-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved point and ring sources #51
Improved point and ring sources #51
Conversation
Additionally updated tests to ensure these parts work, and moved details for DT/DD fuels to a new dataclass.
Codecov Report
@@ Coverage Diff @@
## develop #51 +/- ##
===========================================
+ Coverage 94.50% 96.75% +2.25%
===========================================
Files 6 7 +1
Lines 200 216 +16
===========================================
+ Hits 189 209 +20
+ Misses 11 7 -4
Continue to review full report at Codecov.
|
Thanks @LiamPattinson this PR looks great to me, I like the separation of the fuel part and the reuse of this class in both the ring source and point source. As you mention this will help if #37 goes ahead. I think we can merge this unless there are any objections @RemDelaporteMathurin I have a slight related question on proper_tea as a dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, happy to merge unless there are any objections
I've updated FusionPointSource and FusionRingSource to store their inputs as properties, which allows them to be checked for validity. Info on DT/DD fuel types has been moved to a new class, which may be refactored later if work on Issue #37 goes ahead. I've also added unit tests for these new features.