fix IS_CYGWIN (was not working anyway), replaced by test on env variable ConEmuANSI=ON #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t on env variable ConEmuANSI=ON
|
kept ConEmu support part of the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…was typo "!"
IS_CYGWIN = ... !"cygwin".equals(System.getenv("TERM")
instead of
IS_CYGWIN = ... "cygwin".equals(System.getenv("TERM")
notice that in a windows cmd.exe console, the jansi mode "WINDOWS" works fine ... this is independent of the fact that the process "bash.exe" from cygwin is running
notice also that on windows, a very frequent usage is to use cmder console emulator (https://cmder.net/) + cygwin
The cmder console define several environment variables, including
ConEmuANSI="ON"
which could be tested to use the standard ANSI mode of jansi