accept ForeignInclude attributes on methods (beta-3.0) #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This accepts ForeignInclude attributes on methods and types, instead of just types. Specifying the ForeignInclude attribute on the method it is used (rather than the whole type) makes things more coherent. * Update existing ForeignInclude attributes in the code-base
mortend
force-pushed
the
foreign-include
branch
2 times, most recently
from
ab2bfd0 to
effa3d8
Compare
This makes it possible to accept an array of constants (or use params) in attribute constructors, enabling us to make some code a bit nicer (ForeignIncludeAttribute and ForeignAnnotatonAttribute). * Implement NewArray.ConstantValue * Modify Expression.ConstantString to serialize arrays (via ToString()) * Remove unused method in NewObject * Remove redundant 'env' parameter in ForeignHelpers * Update UnoDoc backend
This removes a bunch of redundant constructors from ForeignIncludeAttribute and ForeignAnnotatonAttribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnoCore: use params in Foreign attributes
This removes a bunch of redundant constructors from
ForeignIncludeAttribute and ForeignAnnotatonAttribute.
compiler: support array arguments in attributes
This makes it possible to accept an array of constants (or use params)
in attribute constructors, enabling us to make some code a bit nicer
(ForeignIncludeAttribute and ForeignAnnotatonAttribute).
compiler: accept ForeignInclude attributes on methods
This accepts ForeignInclude attributes on methods and types, instead of
just types. Specifying the ForeignInclude attribute on the method it is
used (rather than the whole type) makes things more coherent.