compiler: return "if-test and throw" when compiling 'assert' (beta-3.0) #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'assert' statements were turned into method calls to a method that was removed in 992b515, resulting in compile errors. 'assert' is still used in a few places, and this commit turns them into "if-test and throw" in debug builds (noop in release builds) to fix the compile errors. assert VALUE; becomes when compiled: if (IS_DEBUG_BUILD && !VALUE) throw new Uno.InvalidOperationException( "Assertion failed: VALUE" );
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'assert' statements were turned into method calls to a method that was removed in 992b515, resulting in compile errors.
'assert' is still used in a few places, and this commit turns them into "if-test and throw" in debug builds (noop in release builds) to fix the compile errors.
becomes when compiled: