Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnoCore: strip Byte Order Mark for UTF-8 #251

Merged
merged 2 commits into from
Nov 10, 2019
Merged

UnoCore: strip Byte Order Mark for UTF-8 #251

merged 2 commits into from
Nov 10, 2019

Conversation

mortend
Copy link
Member

@mortend mortend commented Nov 5, 2019

When loading files using BundleFile.ReadAllText().
This is consistent with File.ReadAllText().

@mortend
UnoCore: strip Byte Order Mark for UTF-8
fe02494 
When loading files using BundleFile.ReadAllText().
This is consistent with File.ReadAllText().
kusma
kusma approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@kusma kusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@kusma
Copy link
Contributor

kusma commented Nov 6, 2019

Maybe we should have a test for this also?

@mortend mortend merged commit faf5f6f into fuse-open:master Nov 10, 2019
@mortend mortend deleted the bundle-bom branch November 10, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusma kusma kusma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortend @kusma