removing temp. fix for ragg

furrer-lab · Sep 11, 2024 · 411e45b · 411e45b
1 parent 4162bc9
commit 411e45b
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 34 deletions.
diff --git a/.github/workflows/Fedora_setup.yml b/.github/workflows/Fedora_setup.yml
@@ -6,7 +6,6 @@ on:
   push:
     branches:
       - "main"
-      - "150-fails-to-build-dependency-ragg-when-installing"
 
 env:
   JAGS: '4.3.2'
@@ -79,11 +78,6 @@ jobs:
       #     library('abn')
       #   shell: Rscript {0}
 
-      - name: temporal workaround for ragg
-        run: |
-          pak::pak("r-lib/ragg@0bc4e8c")
-        shell: Rscript {0}
-
       - name: pak install from GitHub
         run: |
           pak::repo_add(INLA = "https://inla.r-inla-download.org/R/stable/")

diff --git a/.github/workflows/Macos_setup.yml b/.github/workflows/Macos_setup.yml
@@ -6,7 +6,6 @@ on:
   push:
     branches:
       - "main"
-      - "150-fails-to-build-dependency-ragg-when-installing"
 
 env:
   BUILD_LOC: "./build"
@@ -69,11 +68,6 @@ jobs:
       #     pak::pkg_install('abn', dependencies=TRUE)
       #     library('abn')
       #   shell: Rscript {0}
-
-      - name: temporal workaround for ragg
-        run: |
-          pak::pak("r-lib/ragg@0bc4e8c")
-        shell: Rscript {0}
 
       - name: pak install from GitHub
         run: |

diff --git a/.github/workflows/Ubuntu_setup.yml b/.github/workflows/Ubuntu_setup.yml
@@ -6,7 +6,6 @@ on:
   push:
     branches:
       - "main"
-      - "150-fails-to-build-dependency-ragg-when-installing"
 
 env:
   BRANCH: ${{ github.head_ref || github.ref_name }}
@@ -57,11 +56,6 @@ jobs:
       #     library('abn')
       #   shell: Rscript {0}
 
-      - name: temporal workaround for ragg
-        run: |
-          pak::pak("r-lib/ragg@0bc4e8c")
-        shell: Rscript {0}
-
       - name: pak install from GitHub
         run: |
           pak::repo_add(INLA = "https://inla.r-inla-download.org/R/stable/")

diff --git a/.github/workflows/Windows_setup.yml b/.github/workflows/Windows_setup.yml
@@ -6,7 +6,6 @@ on:
   push:
     branches:
       - "main"
-      - "150-fails-to-build-dependency-ragg-when-installing"
 
 env:
   BUILD_LOC: "./build"
@@ -62,11 +61,6 @@ jobs:
       #     library('abn')
       #   shell: Rscript {0}
 
-      - name: temporal workaround for ragg
-        run: |
-          pak::pak("r-lib/ragg@0bc4e8c")
-        shell: Rscript {0}
-
       - name: pak install from GitHub
         run: |
           pak::repo_add(INLA = "https://inla.r-inla-download.org/R/stable/")

diff --git a/README.md b/README.md
@@ -298,16 +298,6 @@ Officially supported is R version >= 4.4
 
 ## Installing from GitHub (recommended)
 
-> [!WARNING]
-> Due to https://github.com/r-lib/ragg/issues/170 the R package [`ragg`](https://github.com/r-lib/ragg) does not build correctly.
-> Since `abn` depends on `ragg` the installation of `abn` might fail.
-> Therefore, we recommend installing a specific version of `ragg` as a temporal fix:
-> ```R
-> pak::pak("r-lib/ragg@0bc4e8c")
-> ```
-> Simply run this command before installing `abn` (see below) and you should be good to go.
-
-
 From GitHub you can install any version and/or state of the `abn` repository you want.
 We recommend to not directly install `main`, but to a specific version.
 Head over to our [version list](https://github.com/furrer-lab/abn/releases) to see which one is the latest version.