remove python_2_unicode_compatible that no longer exists in django 3 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have to provide information in README for compatible versions. |
|
Yes, will do. Thanks! |
|
Due to lack of activity, should I recreate a PR with an update to the README? This would probably result in a version bump from 0.2.1 to 0.3.0? |
|
My apologies. I got sidetracked between a new job and all this COVID stuff. I will push a commit momentarily. |
|
I did not merge this because I wanted to make the commits individually. This was helpful, particularly the discussion on the version bump and compatibility. In lieu of this pull, these commits handle the changes:
Many thanks to @msarahan, @moritz89 and @LifeMoroz for contributing to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #91
this arguably breaks python 2 in some ways. I can spend a bit more time on this if you'd prefer to maintain python 2 support, even though it is beyond its supported lifetime.