Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Refactor options package names #66

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Apr 22, 2022

Updates naming of symbols and files in the core/options package to be more standardized.

Also exposed a GetOptionDefaultValue which returns the raw default value prior to evaluation.

@irvinlim irvinlim added the kind/refactor Issues identifying refactors needed or PRs to perform refactors label Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #66 (c5ebcd7) into main (a55d7a2) will decrease coverage by 0.13%.
The diff coverage is 87.64%.

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   61.06%   60.92%   -0.14%     
==========================================
  Files         168      170       +2     
  Lines        8447     8486      +39     
==========================================
+ Hits         5158     5170      +12     
- Misses       3047     3070      +23     
- Partials      242      246       +4     
Impacted Files Coverage Δ
pkg/core/options/substitution.go 100.00% <ø> (ø)
pkg/core/options/default.go 65.16% <63.15%> (-11.76%) ⬇️
pkg/core/options/mutation.go 95.00% <95.00%> (ø)
pkg/core/options/validation.go 97.93% <97.93%> (-2.07%) ⬇️
pkg/core/options/options.go 90.24% <100.00%> (-4.02%) ⬇️
pkg/core/options/util.go 100.00% <100.00%> (ø)
pkg/execution/mutation/mutation.go 88.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a55d7a2...c5ebcd7. Read the comment docs.

@irvinlim irvinlim merged commit 45d7c42 into main Apr 22, 2022
@irvinlim irvinlim deleted the irvinlim/chore/rename-options branch April 22, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Issues identifying refactors needed or PRs to perform refactors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant