Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): Add panic stack trace logs #61

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Conversation

irvinlim
Copy link
Member

Adds stack traces to panic in webhook handlers. Adds to work done for #59.

@irvinlim irvinlim added kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features. area/webhooks Related to validating and mutating admission webhooks. labels Apr 17, 2022
@irvinlim irvinlim linked an issue Apr 17, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #61 (8f1c580) into main (487cc8e) will decrease coverage by 0.11%.
The diff coverage is 72.72%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   61.14%   61.02%   -0.12%     
==========================================
  Files         166      166              
  Lines        8395     8406      +11     
==========================================
- Hits         5133     5130       -3     
- Misses       3022     3034      +12     
- Partials      240      242       +2     
Impacted Files Coverage Δ
pkg/runtime/httphandler/webhooks.go 77.77% <72.72%> (-0.45%) ⬇️
...kg/execution/controllers/croncontroller/metrics.go 14.28% <0.00%> (-85.72%) ⬇️
pkg/runtime/reconciler/metrics.go 42.10% <0.00%> (-26.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487cc8e...8f1c580. Read the comment docs.

@irvinlim irvinlim merged commit 3e93e53 into main Apr 17, 2022
@irvinlim irvinlim deleted the irvinlim/fix/panic-logs branch April 17, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webhooks Related to validating and mutating admission webhooks. kind/enhancement Categorizes issues or PRs related to enhancements, rather than full features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant