Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execution): Add tests for JobConfigController, update JobReference fields #58

Merged
merged 4 commits into from
Apr 17, 2022

Conversation

irvinlim
Copy link
Member

  • Adds reconciler tests for JobConfigController.
  • Update JobReference fields to remove namespace (all Jobs must be in the same namespace) and add creationTimestamp and startTime.

@irvinlim irvinlim added component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) area/testing Related to automated testing labels Apr 17, 2022
@codecov
Copy link

codecov bot commented Apr 17, 2022

Codecov Report

Merging #58 (d571be6) into main (c828eea) will increase coverage by 2.90%.
The diff coverage is 81.13%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   57.27%   60.17%   +2.90%     
==========================================
  Files         165      166       +1     
  Lines        8318     8369      +51     
==========================================
+ Hits         4764     5036     +272     
+ Misses       3321     3097     -224     
- Partials      233      236       +3     
Impacted Files Coverage Δ
apis/execution/v1alpha1/jobconfig_types.go 100.00% <ø> (ø)
pkg/runtime/testing/action.go 72.41% <20.00%> (-10.92%) ⬇️
...tion/controllers/jobconfigcontroller/controller.go 35.29% <70.00%> (+35.29%) ⬆️
pkg/runtime/testing/reconciler.go 75.91% <71.42%> (-1.59%) ⬇️
pkg/runtime/testing/recorder.go 88.88% <88.88%> (ø)
apis/execution/v1alpha1/zz_generated.deepcopy.go 58.69% <100.00%> (+3.46%) ⬆️
...xecution/controllers/jobconfigcontroller/differ.go 100.00% <100.00%> (+100.00%) ⬆️
...tion/controllers/jobconfigcontroller/reconciler.go 85.96% <100.00%> (+85.96%) ⬆️
.../execution/controllers/jobconfigcontroller/util.go 100.00% <100.00%> (+100.00%) ⬆️
pkg/utils/execution/jobconfig/job_utils.go 76.56% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c828eea...d571be6. Read the comment docs.

@irvinlim irvinlim force-pushed the irvinlim/chore/jobconfigcontroller-tests branch from 2b6c70f to d571be6 Compare April 17, 2022 15:14
@irvinlim irvinlim merged commit 4bedf16 into main Apr 17, 2022
@irvinlim irvinlim deleted the irvinlim/chore/jobconfigcontroller-tests branch April 17, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to automated testing component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant