Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(execution): Bump LastUpdated on schedule update #52

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Apr 15, 2022

Closes #50 and #12.

  • Separate spec.schedule.constraints.notBefore to spec.schedule.lastUpdated, to avoid conflation of server-managed field vs user-defined fields.
  • Add notAfter constraint, the dual of notBefore.
  • Fixes JobConfigMutatingWebhook to handle case when cron was not updated but disabled was updated.

@irvinlim irvinlim added kind/bug Categorizes issue or PR as related to a bug. component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) labels Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #52 (8d93151) into main (031b4ff) will increase coverage by 0.01%.
The diff coverage is 81.57%.

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   54.69%   54.71%   +0.01%     
==========================================
  Files         163      163              
  Lines        8128     8133       +5     
==========================================
+ Hits         4446     4450       +4     
- Misses       3474     3477       +3     
+ Partials      208      206       -2     
Impacted Files Coverage Δ
apis/execution/v1alpha1/jobconfig_types.go 100.00% <ø> (ø)
...tion/controllers/jobconfigcontroller/reconciler.go 0.00% <0.00%> (ø)
apis/execution/v1alpha1/zz_generated.deepcopy.go 55.22% <40.00%> (-1.39%) ⬇️
...g/execution/controllers/croncontroller/schedule.go 86.58% <100.00%> (+1.25%) ⬆️
pkg/execution/mutation/mutation.go 89.18% <100.00%> (+4.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031b4ff...8d93151. Read the comment docs.

@irvinlim irvinlim merged commit 3e131b7 into main Apr 16, 2022
@irvinlim irvinlim deleted the irvinlim/fix/schedule-constraints-webhook branch April 16, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scheduling Related to execution scheduling (e.g. cron, concurrency, etc) component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: CronController performs back-scheduling when re-enabling JobConfig
1 participant