Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(runtime): Add controllermanager tests #44

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Apr 11, 2022

Adds unit tests for controllermanager.

@irvinlim irvinlim added the area/testing Related to automated testing label Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@838149a). Click here to learn what that means.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main      #44   +/-   ##
=======================================
  Coverage        ?   54.47%           
=======================================
  Files           ?      163           
  Lines           ?     8095           
  Branches        ?        0           
=======================================
  Hits            ?     4410           
  Misses          ?     3477           
  Partials        ?      208           
Impacted Files Coverage Δ
cmd/execution-controller/main.go 0.00% <0.00%> (ø)
pkg/runtime/controllermanager/controller.go 91.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 838149a...43e0b7b. Read the comment docs.

@irvinlim irvinlim force-pushed the irvinlim/chore/add-controllermanager-tests branch from bd75fd7 to 43e0b7b Compare April 11, 2022 18:03
@irvinlim irvinlim merged commit 4aaa25b into main Apr 11, 2022
@irvinlim irvinlim deleted the irvinlim/chore/add-controllermanager-tests branch April 11, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant