Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cron): Add unit tests for CronWorker #39

Merged
merged 7 commits into from
Apr 10, 2022

Conversation

irvinlim
Copy link
Member

Adds unit tests for CronWorker.

@irvinlim irvinlim added the area/testing Related to automated testing label Apr 10, 2022
@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #39 (f7d0ae1) into main (7b79cd4) will increase coverage by 2.16%.
The diff coverage is 65.57%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   49.73%   51.89%   +2.16%     
==========================================
  Files         161      162       +1     
  Lines        7991     8024      +33     
==========================================
+ Hits         3974     4164     +190     
+ Misses       3834     3664     -170     
- Partials      183      196      +13     
Impacted Files Coverage Δ
...execution/controllers/croncontroller/controller.go 23.68% <0.00%> (-0.65%) ⬇️
...xecution/controllers/croncontroller/cron_worker.go 71.24% <58.82%> (ø)
pkg/utils/testutils/klog.go 60.00% <60.00%> (ø)
...g/execution/controllers/croncontroller/informer.go 71.15% <100.00%> (+71.15%) ⬆️
pkg/execution/controllers/croncontroller/ticker.go 100.00% <100.00%> (ø)
.../runtime/controllercontext/mock/context_configs.go 81.39% <100.00%> (+1.90%) ⬆️
pkg/execution/controllers/croncontroller/util.go 90.90% <0.00%> (+9.09%) ⬆️
...ed/typed/execution/v1alpha1/fake/fake_jobconfig.go 42.25% <0.00%> (+14.08%) ⬆️
pkg/utils/eventhandler/executionv1alpha1.go 40.00% <0.00%> (+20.00%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b79cd4...f7d0ae1. Read the comment docs.

@irvinlim irvinlim merged commit a3c78ff into main Apr 10, 2022
@irvinlim irvinlim deleted the irvinlim/feat/cron-worker-tests branch April 10, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Related to automated testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant