Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use config.furiko.io/v1alpha1 for all Config API types #36

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Apr 8, 2022

We change the config.furiko.io/v1 API group to config.furiko.io/v1alpha1 first.

The API version of config.furiko.io is NOT the same as the API version of other APIs, e.g. execution.furiko.io. It is simply meant to signify that the configuration format is currently in alpha state.

@irvinlim irvinlim added area/api Related to public APIs, including CRD design, configuration, etc area/configuration Related to user-defined configuration of the operator labels Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #36 (acefa7a) into main (96bb8ca) will not change coverage.
The diff coverage is 40.00%.

@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   49.74%   49.74%           
=======================================
  Files         159      159           
  Lines        7988     7988           
=======================================
  Hits         3974     3974           
  Misses       3831     3831           
  Partials      183      183           
Impacted Files Coverage Δ
apis/config/v1alpha1/managerconfig_types.go 100.00% <ø> (ø)
apis/config/v1alpha1/webhookconfig_types.go 100.00% <ø> (ø)
apis/config/v1alpha1/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
cmd/execution-controller/main.go 0.00% <0.00%> (ø)
cmd/execution-webhook/main.go 0.00% <0.00%> (ø)
...execution/controllers/croncontroller/controller.go 23.07% <ø> (ø)
pkg/execution/controllers/croncontroller/cron.go 0.00% <0.00%> (ø)
...kg/execution/controllers/croncontroller/factory.go 0.00% <ø> (ø)
...execution/controllers/croncontroller/reconciler.go 87.34% <ø> (ø)
...tion/controllers/jobconfigcontroller/controller.go 0.00% <ø> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96bb8ca...acefa7a. Read the comment docs.

@irvinlim irvinlim merged commit 9b8e22b into main Apr 8, 2022
@irvinlim irvinlim deleted the irvinlim/chore/dynamic-config-versioning branch April 8, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to public APIs, including CRD design, configuration, etc area/configuration Related to user-defined configuration of the operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant