WIP: switch to using backblaze for images #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mirlo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
simonv3
commented
Dec 19, 2024
| overshootDeringing: true, // required mozjpeg support | ||
| }, | ||
| }, | ||
| // jpeg: { |
There was a problem hiding this comment.
So I'm getting rid of these because they're not getting used in the UI, and I can't quite imagine why they'd get used, and we can always generate them in the future?
simonv3
commented
Dec 19, 2024
| // seems to not like it when we bombard it with files all in one go, | ||
| // so when we do Promise.all at the end of this we're sending all the | ||
| // files and it just doesn't process anything but the first one. | ||
| await sleep((i + 1) * (j + 1) * 1500); |
There was a problem hiding this comment.
Having to sleep in these promises because if I don't then backblaze seems to get overwhelmed and returns an error 408
simonv3
commented
Dec 19, 2024
| // FIXME: someone who's better at devops than me will have to figure out | ||
| // how we can serve these directly from minio | ||
| try { | ||
| stat = await minioClient.statObject(req.params.bucket, req.params.filename); | ||
| backblazeStat = await backblazeClient.send( |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a punt that switches to using backblaze for images