-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Looks nice, thank you! Could you throw in a small unittest for it? |
done |
Thanks! I'll take a look on Monday, since I'm on a short holiday now. (yay!) If I don't get back to you by Tuesday, I've lost the notification so please give me a ping by then. :) |
Sorry for the late reply! I meant, could you throw in a small unittest in Looks good otherwise. (Also, rebase on master please :) ) |
Can you explain more? |
|
It is a bad omen to use rebase :-) |
This can be checked by coverage analyzis Sorry, I already removed serialized dependency from my srcs, so this PR isn't actual for me. |
Fair nuf :) Thanks anyway. |
Proposal about #4
How to use: