Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key error bug in iou #8

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Fix key error bug in iou #8

merged 2 commits into from
Apr 4, 2024

Conversation

cmalinmayor
Copy link
Collaborator

Proposed Change

Found a bug that wasn't caught by our tests because they are too small. No longer try to set IOU for non-existing edges.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (7820cca) to head (2aecf79).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   83.90%   83.95%   +0.05%     
==========================================
  Files          12       12              
  Lines         292      293       +1     
==========================================
+ Hits          245      246       +1     
  Misses         47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor cmalinmayor merged commit c72b59b into main Apr 4, 2024
6 checks passed
@cmalinmayor cmalinmayor deleted the bugfix_iou branch April 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants