Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute iou #4

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Compute iou #4

merged 3 commits into from
Mar 19, 2024

Conversation

cmalinmayor
Copy link
Collaborator

Proposed Change

Add IOU computation to candidate graph creation.
I tried doing the np.unique shortcut for IOU computation, but I had to tinker with it. Will check against a reference implementation before merging to see if it can be more efficient.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.14286% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.21%. Comparing base (b8b215f) to head (8e0616c).

Files Patch % Lines
...toolbox/candidate_graph/graph_from_segmentation.py 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   75.56%   78.21%   +2.64%     
==========================================
  Files           9        9              
  Lines         176      202      +26     
==========================================
+ Hits          133      158      +25     
- Misses         43       44       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor cmalinmayor merged commit 6811521 into main Mar 19, 2024
6 checks passed
@cmalinmayor cmalinmayor deleted the compute_iou branch March 19, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants