Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass scale to regionprops when getting cand graph nodes #20

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

cmalinmayor
Copy link
Collaborator

Proposed Change

Allow passing a scale when constructing a candidate graph. The scale is then passed to regionprops for computing region properties.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

Further Comments

Scale currently includes time, and is passed a list of floats. The list of floats will change when we use funlib persistence (only ints allowed), but the inclusion of time is already future-proofed.

Copy link
Collaborator

@AnniekStok AnniekStok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.97%. Comparing base (cdc12a4) to head (7b05b5c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   86.88%   86.97%   +0.09%     
==========================================
  Files          14       14              
  Lines         427      430       +3     
==========================================
+ Hits          371      374       +3     
  Misses         56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmalinmayor cmalinmayor merged commit 7ebd9c1 into main Sep 16, 2024
4 checks passed
@cmalinmayor cmalinmayor deleted the scale_attrs branch September 16, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants