Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split graph creation #1

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Split graph creation #1

merged 3 commits into from
Feb 28, 2024

Conversation

cmalinmayor
Copy link
Collaborator

@cmalinmayor cmalinmayor commented Feb 28, 2024

Proposed Change

Split candidate graph creation into two functions, one that extracts nodes from a segmentation, and the other that adds edges. This allows the edge adding to be done the same way even if the detections are not from a segmentation.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.
  • I have checked that mypy type checking passes.

@cmalinmayor cmalinmayor merged commit 6be58a6 into main Feb 28, 2024
6 checks passed
@cmalinmayor cmalinmayor deleted the split_graph_creation branch February 28, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant