Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure python rewrite #70

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Pure python rewrite #70

wants to merge 21 commits into from

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Dec 19, 2024

Here's the big one!

This PR would thank @funkey's C++ code for its service and move to a pure python interface where we dispatch to gurobipy or PySCIPOpt for the backend implementations (both of which are available on pypi and conda!).

This makes ilpy (and therefore motile) dramatically easier to distribute, even just with pypi (no conda needed at all). End users can pip install gurobipy or conda install -c gurobipy if they have a license and want to bring it in.

all tests are currently passing locally with essentially no changes to the test suite. So i think the public API should be essentially untouched.

cc @cmalinmayor, @funkey

closes #68
closes #69

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 79.13669% with 87 lines in your changes missing coverage. Please review.

Project coverage is 85.06%. Comparing base (0fdfae7) to head (88202a6).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/ilpy/solver_backends/_gurobi.py 34.28% 46 Missing ⚠️
src/ilpy/_components.py 84.67% 19 Missing ⚠️
src/ilpy/solver_backends/_scip.py 81.92% 15 Missing ⚠️
src/ilpy/_solver.py 90.90% 5 Missing ⚠️
src/ilpy/__init__.py 95.00% 1 Missing ⚠️
src/ilpy/solver_backends/__init__.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
+ Coverage   75.72%   85.06%   +9.34%     
==========================================
  Files          17       10       -7     
  Lines         828      663     -165     
  Branches      154        0     -154     
==========================================
- Hits          627      564      -63     
+ Misses        136       99      -37     
+ Partials       65        0      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

still need to reimplement callbacks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant