Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ILPY_PREFERENCE env var #59

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Conversation

tlambert03
Copy link
Member

@tlambert03 tlambert03 commented Apr 22, 2024

this PR makes it so that you can select the default solver using ILPY_PREFERENCE=scip or ILPY_PREFERENCE=gurobi. this makes it easier to quickly swap backends without changing code. It only changes what happens when a solver is created without an explicit preference, one can still pass preference=Preference.Any etc. If an environment-specified backend is not available, it will cause an error unless Preference.Any is explicitly passed

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 59.15%. Comparing base (0fdfae7) to head (2b49f01).
Report is 6 commits behind head on main.

Files Patch % Lines
ilpy/wrapper.pyx 50.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #59       +/-   ##
===========================================
- Coverage   75.72%   59.15%   -16.58%     
===========================================
  Files          17       19        +2     
  Lines         828     1087      +259     
  Branches      154      306      +152     
===========================================
+ Hits          627      643       +16     
- Misses        136      420      +284     
+ Partials       65       24       -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 5dc9202 into funkelab:main Apr 22, 2024
17 of 19 checks passed
@tlambert03 tlambert03 deleted the env_var branch April 22, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant