Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel wise intensity #217

Open
wants to merge 2 commits into
base: patch-1.4.1
Choose a base branch
from
Open

Channel wise intensity #217

wants to merge 2 commits into from

Conversation

pattonw
Copy link
Collaborator

@pattonw pattonw commented Dec 9, 2024

Pre-Merge Checklist:

  • if this PR adds a feature: request merge into the latest development branch (vX.Y-dev)
  • if this PR fixes a bug: request merge into the latest patch branch (patch-X.Y.Z)
  • PR branch name is short and describes the feature/bug addressed in this PR
  • commit messages are consistent
  • changes reviewed by another contributor
  • tests cover changes
  • all tests pass

Merging into a patch branch because we are adding a feature, but it is simply generalizing the existing limited slabing across z-slices to generalized slicing across arbitrary dimensions and slice sizes.

Addressing #216

Currently we support intensity shifts accross z slices, but we have a concept of slabs in other nodes providing much more freedom over which axes and step sizes get augmented independently.
This change depricates the z_section_wise argument in favor of slabs, but keeps support for both for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant