Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device arg to torch train and predict #188 #196

Closed
wants to merge 9 commits into from

Conversation

Mohinta2892
Copy link

@Mohinta2892 Mohinta2892 commented Nov 2, 2023

Pre-Merge Checklist:

  • if this PR adds a feature: request merge into the latest development branch (patch-1.3.2)
  • if this PR fixes a bug: request merge into the latest patch branch (patch-X.Y.Z)
  • PR branch name is short and describes the feature/bug addressed in this PR Passing cuda device as an argument to Train, Predict nodes #188
  • commit messages are consistent
  • changes reviewed by another contributor
  • tests cover changes
  • all tests pass

allow passing cuda device to Train
Allow passing cuda device to Predict. Issue funkelab#188
@pattonw
Copy link
Collaborator

pattonw commented Nov 2, 2023

please target patch-1.3.2, and run black to make spacings consistent

@Mohinta2892
Copy link
Author

Hi Will,

Thanks, reformatted with black!

@pattonw
Copy link
Collaborator

pattonw commented Nov 2, 2023

Hi Samia, Thanks! but no need to reformat unrelated files, just the ones you modified would be great

This reverts commit 66dd69b.

Only format changed files, since black does not consider formatting history
This reverts commit 0fd3bff.
@Mohinta2892
Copy link
Author

Sorry, fixed.

@pattonw
Copy link
Collaborator

pattonw commented Dec 19, 2023

squashed and merged into the patch branch

@pattonw pattonw closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants