-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add features from cellmap fork #4
Conversation
Ome zarr reading
…zarr and .n5 stores
Read voxel size, offset, and units from metadata for an input array.
changes were made by @yuriyzubov, so he'd probably give the best summary. |
Added checking for legacy attributes in zarr metadata
@yuriyzubov can you please explain what you did ? |
These changes facilitate use of funlib.persistence with multi-resolution OME-NGFF Zarr containers, as used by CellMap. This is a core dependency to DaCapo and needs to be updated on PyPi before DaCapo can be published. @yuriyzubov Are there any further additions you would like to make? |
|
@yuriyzubov @d-v-b Can you please take a look here |
I can confirm that |
@rhoadesScholar I unassigned myself, because it's not clear what you need from me in this PR |
I assigned you, @d-v-b , because you created the PR and pair well with @yuriyzubov to complete remaining issues. After that I'll merge it. Thanks! |
maybe list these issues here? I don't know what they are :) |
to be clear, I opened the PR because someone needs to open a PR to bring the cellmap stuff into this repo, but none of the commits in here are mine 🤣, and I'm not a maintainer of this repo |
The remaining issue: |
@rhoadesScholar can you summarize the changes from the cellmap fork?