raise NotImplemented errors

funkelab · May 11, 2023 · 96bd8a7 · 96bd8a7
1 parent c88ac48
commit 96bd8a7
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 22 deletions.
diff --git a/funlib/persistence/graphs/file_graph_provider.py b/funlib/persistence/graphs/file_graph_provider.py
@@ -416,18 +416,19 @@ def write_edges(
         fail_if_not_exists=False,
         delete=False,
     ):
-        assert not delete, "Delete not implemented"
         assert not (
             fail_if_exists and fail_if_not_exists
         ), "Cannot have fail_if_exists and fail_if_not_exists simultaneously"
+        if delete:
+            raise NotImplementedError("Delete not implemented for file backend")
         if fail_if_exists:
-            raise RuntimeError("Fail if exists not implemented for " "file backend")
+            raise NotImplementedError("Fail if exists not implemented for file backend")
         if fail_if_not_exists:
-            raise RuntimeError("Fail if not exists not implemented for " "file backend")
+            raise NotImplementedError("Fail if not exists not implemented for file backend")
         if attributes is not None:
-            raise RuntimeError("Attributes not implemented for file backend")
+            raise NotImplementedError("Attributes not implemented for file backend")
         if self.graph_provider.mode == "r":
-            raise RuntimeError("Trying to write to read-only DB")
+            raise NotImplementedError("Trying to write to read-only DB")
         if roi is None:
             roi = self.roi
 
@@ -470,18 +471,19 @@ def write_nodes(
         fail_if_not_exists=False,
         delete=False,
     ):
-        assert not delete, "Delete not implemented"
         assert not (
             fail_if_exists and fail_if_not_exists
         ), "Cannot have fail_if_exists and fail_if_not_exists simultaneously"
+        if delete:
+            raise NotImplementedError("Delete not implemented for file backend")
         if fail_if_exists:
-            raise RuntimeError("Fail if exists not implemented for " "file backend")
+            raise NotImplementedError("Fail if exists not implemented for " "file backend")
         if fail_if_not_exists:
-            raise RuntimeError("Fail if not exists not implemented for " "file backend")
+            raise NotImplementedError("Fail if not exists not implemented for " "file backend")
         if attributes is not None:
-            raise RuntimeError("Attributes not implemented for file backend")
+            raise NotImplementedError("Attributes not implemented for file backend")
         if self.graph_provider.mode == "r":
-            raise RuntimeError("Trying to write to read-only DB")
+            raise NotImplementedError("Trying to write to read-only DB")
 
         if roi is None:
             roi = self.roi
@@ -528,7 +530,7 @@ def __contains(self, roi, node):
         return roi.contains(Coordinate(node_data["position"]))
 
     def is_directed(self):
-        raise RuntimeError("not implemented in %s" % self.name())
+        raise NotImplementedError("not implemented in %s" % self.name())
 
 
 class FileSubGraph(FileSharedSubGraph, Graph):

diff --git a/funlib/persistence/graphs/mongodb_graph_provider.py b/funlib/persistence/graphs/mongodb_graph_provider.py
@@ -489,9 +489,7 @@ def __disconnect(self):
         self.edges = None
         self.meta = None
         self.database = None
-        if self.client:
-            self.client.close()
-            self.client = None
+        self.client = None
 
     def __create_node_collection(self):
         """Creates the node collection, including indexes"""
@@ -633,7 +631,8 @@ def write_nodes(
         fail_if_not_exists=False,
         delete=False,
     ):
-        assert not delete, "Delete not implemented"
+        if delete:
+            raise NotImplementedError("Delete not implemented for file backend")
         assert not (
             fail_if_exists and fail_if_not_exists
         ), "Cannot have fail_if_exists and fail_if_not_exists simultaneously"
@@ -691,7 +690,8 @@ def write_edges(
         fail_if_not_exists=False,
         delete=False,
     ):
-        assert not delete, "Delete not implemented"
+        if delete:
+            raise NotImplementedError("Delete not implemented for file backend")
         assert not (
             fail_if_exists and fail_if_not_exists
         ), "Cannot have fail_if_exists and fail_if_not_exists simultaneously"
@@ -710,6 +710,7 @@ def write_edges(
         for u, v, data in self.edges(data=True):
             if not self.is_directed():
                 u, v = min(u, v), max(u, v)
+
             if not self.__contains(roi, u):
                 logger.debug(
                     (
@@ -904,7 +905,8 @@ def __write(
 
                 see write_nodes or write_edges for explanations of these flags
         """
-        assert not delete, "Delete not implemented"
+        if delete:
+            raise NotImplementedError("Delete not implemented for file backend")
         match_docs = []
         for doc in docs:
             match_doc = {}
@@ -977,7 +979,7 @@ def __contains(self, roi, node):
         return roi.contains(Coordinate(coordinate))
 
     def is_directed(self):
-        raise RuntimeError("not implemented in %s" % self.name())
+        raise NotImplementedError("not implemented in %s" % self.name())
 
 
 class MongoDbSubGraph(MongoDbSharedSubGraph, Graph):

diff --git a/funlib/persistence/graphs/shared_graph_provider.py b/funlib/persistence/graphs/shared_graph_provider.py
@@ -25,7 +25,7 @@ class SharedGraphProvider(object):
     """
 
     def __getitem__(self, roi):
-        raise RuntimeError("not implemented in %s" % self.name())
+        raise NotImplementedError("not implemented in %s" % self.name())
 
     def name(self):
         return type(self).__name__
@@ -61,7 +61,7 @@ def write_edges(
                 in subgraph.
 
         """
-        raise RuntimeError("not implemented in %s" % self.name())
+        raise NotImplementedError("not implemented in %s" % self.name())
 
     def write_nodes(
         self,
@@ -93,13 +93,13 @@ def write_nodes(
                 in subgraph.
 
         """
-        raise RuntimeError("not implemented in %s" % self.name())
+        raise NotImplementedError("not implemented in %s" % self.name())
 
     def get_connected_components(self):
         """Returns a list of connected components from the nodes and edges
         in the subgraph. For directed graphs, weak connectivity is sufficient.
         """
-        raise RuntimeError("not implemented in %s" % self.name())
+        raise NotImplementedError("not implemented in %s" % self.name())
 
     def name(self):
         return type(self).__name__