Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Loading Spinner]: New Component #527

Merged
merged 19 commits into from
Jan 13, 2025
Merged

[Loading Spinner]: New Component #527

merged 19 commits into from
Jan 13, 2025

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Dec 30, 2024 •
edited
Loading

Jira ticket: https://funidata.atlassian.net/browse/DS-248

  • Introduces new component: Loading Spinner, which is first Stand Alone component in Fudis
  • Tweaked Heading Component, so it is easier to manually focus to native H-element.
  • Created Storybook component for Static Components with (mostly) non-interactive components and removed individual Playwright tests for those now in Static Components Playground

@videoeero videoeero added the feature New feature that is presented for the first time label Dec 30, 2024
@videoeero videoeero marked this pull request as draft December 30, 2024 14:45
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 December 30, 2024 15:29 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 December 30, 2024 15:38 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 December 31, 2024 07:40 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 December 31, 2024 14:32 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 December 31, 2024 14:33 Destroyed
@videoeero videoeero changed the title [Spinner]: New Component [Loading Spinner]: New Component Dec 31, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 December 31, 2024 14:37 Destroyed
@videoeero videoeero marked this pull request as ready for review December 31, 2024 14:37
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 December 31, 2024 15:16 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 January 2, 2025 13:33 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 January 2, 2025 14:29 Destroyed
RiinaKuu
RiinaKuu approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@RiinaKuu RiinaKuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice spinner component 🥇
PR is approved but let's merge this after v4.0.0 has been taken from the current main and include this in our next release.

@github-actions github-actions bot temporarily deployed to Documentation for branch DS-248-spinner-v1 January 13, 2025 09:29 Destroyed
@RiinaKuu RiinaKuu merged commit 55681df into main Jan 13, 2025
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-248-spinner-v1 branch January 13, 2025 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RiinaKuu RiinaKuu RiinaKuu approved these changes

Assignees
No one assigned
Labels
feature New feature that is presented for the first time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@videoeero @RiinaKuu