[Label, Fieldset]: Automagically setting Label heights and DOM refactoring #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
videoeero
changed the title
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
videoeero
changed the title
RiinaKuu
requested changes
Dec 30, 2024
ngx-fudis/projects/ngx-fudis/src/lib/components/form/label/label.component.ts
Show resolved
Hide resolved
...udis/projects/ngx-fudis/src/lib/components/form/checkbox-group/checkbox-group.component.scss
Outdated
Show resolved
Hide resolved
ngx-fudis/projects/ngx-fudis/src/lib/components/form/fieldset/fieldset.component.scss
Show resolved
Hide resolved
ngx-fudis/projects/ngx-fudis/src/lib/components/form/fieldset/fieldset.component.scss
Outdated
Show resolved
Hide resolved
ngx-fudis/projects/ngx-fudis/src/lib/components/form/fieldset/fieldset.component.scss
Outdated
Show resolved
Hide resolved
...jects/ngx-fudis/src/lib/components/form/radio-button-group/radio-button-group.component.scss
Show resolved
Hide resolved
ngx-fudis/projects/ngx-fudis/src/lib/components/section/section.component.html
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
RiinaKuu
previously approved these changes
Dec 30, 2024
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
github-actions
bot
temporarily deployed
to
Documentation for branch DS-428-responsive-label-height
RiinaKuu
approved these changes
Dec 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://funidata.atlassian.net/browse/DS-428
This PR introduces new internal
FudisLabelHeightServicetool, which is consumed by Label Component and Fieldset Component. Service will check each registered Label component and pair them with other Labels which are in the same "row" / vertical position of the view. Then it checks which of the Labels is the heigthest and match other shorter Labels to that, so their related input fields will then align for better UI cohesion.Jira ticket: https://funidata.atlassian.net/browse/DS-334
Fieldset's Legend structure has been refactored to follow guidelines from A11y audit. This affected quite a lot VR images, but this also enabled to make Fieldset's Legend match better Figma designs and to be concise with components using Label.