-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select, Multiselect]: A11y fixes part 2 #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work as intended, no bugs were found!
Small future enhancement: _translationRemoveItem
translation key could be thought again and double check from designers (it might not always be filters user wants to remove but maybe options too?).
And as discussed earlier, let's merge this after stable v4.0.0
has been taken in order to be able to track possible fixes in the next minor/patch version.
[Select, Multiselect]: Update missing unit tests
Jira ticket: https://funidata.atlassian.net/browse/DS-426
From a11y audit the html div element which was used as html input element did not work well enough for screen readers, so this PR refactors both Select and Multiselect to have always a native input element. To make this happen:
In follow up ticket: https://funidata.atlassian.net/browse/DS-431