Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select, Multiselect]: A11y fixes part 2 #516

Merged
merged 49 commits into from
Jan 13, 2025
Merged

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Dec 17, 2024

Jira ticket: https://funidata.atlassian.net/browse/DS-426

From a11y audit the html div element which was used as html input element did not work well enough for screen readers, so this PR refactors both Select and Multiselect to have always a native input element. To make this happen:

  • Created new Select Control Value Accessor directives
  • Created new Select Autocomplete directives
  • Removed whole Select Autocomplete Component, as these new directives provide same functionality with less code
  • Updated unit tests and e2e tests for the crucial parts

In follow up ticket: https://funidata.atlassian.net/browse/DS-431

  • Update and complete unit tests for new directives

@videoeero videoeero marked this pull request as draft December 17, 2024 21:11
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 17, 2024 21:12 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 18, 2024 12:44 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 20, 2024 16:31 Destroyed
@videoeero videoeero marked this pull request as ready for review December 23, 2024 07:34
RiinaKuu
RiinaKuu previously approved these changes Dec 27, 2024
Copy link
Contributor

@RiinaKuu RiinaKuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work as intended, no bugs were found!
Small future enhancement: _translationRemoveItem translation key could be thought again and double check from designers (it might not always be filters user wants to remove but maybe options too?).

And as discussed earlier, let's merge this after stable v4.0.0 has been taken in order to be able to track possible fixes in the next minor/patch version.

@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 28, 2024 00:07 Destroyed
RiinaKuu
RiinaKuu previously approved these changes Dec 30, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 31, 2024 12:57 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 31, 2024 13:36 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 31, 2024 13:45 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 31, 2024 13:57 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input December 31, 2024 15:19 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-426-select-div-to-input January 13, 2025 11:39 Destroyed
@RiinaKuu RiinaKuu merged commit 18fe561 into main Jan 13, 2025
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-426-select-div-to-input branch January 13, 2025 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants