[Select, Expandable]: Refactor content projection directives #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve footer content directive file location
github-actions
bot
temporarily deployed
to
Documentation for branch DS-392-select-expandable-content-projection-update
github-actions
bot
temporarily deployed
to
Documentation for branch DS-392-select-expandable-content-projection-update
github-actions
bot
temporarily deployed
to
Documentation for branch DS-392-select-expandable-content-projection-update
MayaMarjut
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Personally, I would rename this file to expandable-content.directive.ts, so it would follow the same syntax. For example fielset-content.directive also includes content and actions, and furthermore Select Options content projection is named only select-options.directive. Exported name is fine, but maybe change the file name to shorter version?
github-actions
bot
temporarily deployed
to
Documentation for branch DS-392-select-expandable-content-projection-update
MayaMarjut
reviewed
Dec 11, 2024
| import { GridApiDirective } from './directives/grid/grid-api/grid-api.directive'; | ||
| import { GridDirective } from './directives/grid/grid/grid.directive'; | ||
| import { GridItemDirective } from './directives/grid/grid-item/grid-item.directive'; | ||
| import { GroupComponentBaseDirective } from './directives/form/group-component-base/group-component-base.directive'; | ||
|
|
||
| import { LinkDirective } from './directives/link/link.directive'; | ||
| import { SectionActionsDirective } from './directives/content-projection/section/section-content.directive'; | ||
| import { SectionContentDirective } from './directives/content-projection/section/section-content.directive'; | ||
| import { SectionActionsDirective } from './components/section/section-content.directive'; |
There was a problem hiding this comment.
Put these following imports to same path
github-actions
bot
temporarily deployed
to
Documentation for branch DS-392-select-expandable-content-projection-update
github-actions
bot
temporarily deployed
to
Documentation for branch DS-392-select-expandable-content-projection-update
github-actions
bot
temporarily deployed
to
Documentation for branch DS-392-select-expandable-content-projection-update
RiinaKuu
approved these changes
Dec 12, 2024
RiinaKuu
deleted the
DS-392-select-expandable-content-projection-update
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://funidata.atlassian.net/browse/DS-392
As follow up to PR #498 refactoring other components using content projection. Because Expandable Content and Select Options are usually lazy loaded, those directives weren't at this time converted to
<fudis-traditional-selector-syntax>These are still used with<ng-template>but selector was tweaked.Breaking changes and migration guidelines below:
Expandable Actions
Previously in HTML template:
<ng-template fudisActions type="expandable">Now in HTML template:
<fudis-expandable-actions>Previous import name:
ActionsDirectiveCurrent import name:
ExpandableActionsDirectiveExpandable Content
Previously in HTML template:
<ng-template fudisContent type="expandable">Now in HTML template:
<ng-template fudisExpandableContent>Previous import name:
ContentDirectiveCurrent import name:
ExpandableContentDirectiveSelect Options
Previously in HTML template:
<ng-template fudisContent type="select-options">Now in HTML template:
<ng-template fudisSelectOptions>Previous import name:
ContentDirectiveCurrent import name:
SelectOptionsDirective