[Error Summary, Dialog]: Minor CSS changes #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
Documentation for branch adjust-error-summary-positioning
RiinaKuu
reviewed
Dec 4, 2024
| margin-top: spacing.$spacing-xs; | ||
| fudis-notification { | ||
| .fudis-icon-host { | ||
| margin-top: spacing.$spacing-xs; |
There was a problem hiding this comment.
Went through all of the changed images and nothing out of the ordinary stood out but it seems to me that this isn't working at all (and not sure if it should or is the current outcome the wanted one).
There was a problem hiding this comment.
Nice catch. I tested this as well, and this selector should be in different place in the scss file to work. I pushed new commit to clean this away, as it is then closer to Figma designs.
github-actions
bot
temporarily deployed
to
Documentation for branch adjust-error-summary-positioning
github-actions
bot
temporarily deployed
to
Documentation for branch adjust-error-summary-positioning
RiinaKuu
approved these changes
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the work on PR #498 some adjustments were made to Dialog's and Error Summary styles.
As that PR is a breaking change and checking out that Playwright tests are not failing otherwise than these small CSS fixes, this PR was made.