[Checkbox Group, Checkbox]: Adjust Checkbox Group's FormGroup and Checkbox's FormControl type #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
videoeero
added
improvement
videoeero
added
breaking change
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
videoeero
changed the title
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
RiinaKuu
previously approved these changes
Dec 4, 2024
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
github-actions
bot
temporarily deployed
to
Documentation for branch checkbox-group-formgroup-type-adjust
RiinaKuu
approved these changes
Dec 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://funidata.atlassian.net/browse/DS-410
Application developers encountered Typescript typing error with Checkbox Group. After discussion this PR's adjustments were made to address the issue.
Breaking changes:
boolean | null | undefined. After this PR it can beboolean | nullwithout undefined.element: CheckboxGroup-->element: CheckboxGroup<FudisCheckboxGroupFormGroup>orelement: CheckboxGroup<MyType>Slack: https://sisudev.slack.com/archives/C03G46K6LG1/p1733216094386739