-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Section, Form]: Remove default level and titleVariant values, make title and level as required properties #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equired property, adjust titleVariant logic
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
November 28, 2024 15:01
Destroyed
… remove titleVariant default value and add logic to it
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
November 29, 2024 13:37
Destroyed
RiinaKuu
changed the title
[Section]: Remove default level and titleVariant values
[Section, Form]: Remove default level and titleVariant values, make title and level as required properties
Nov 29, 2024
…es in Section and Form components
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
November 29, 2024 16:00
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
November 29, 2024 16:03
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
December 2, 2024 12:46
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
December 2, 2024 13:18
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
December 3, 2024 07:41
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
December 3, 2024 07:49
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
December 3, 2024 08:50
Destroyed
videoeero
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
December 3, 2024 11:53
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-397-section-remove-default-level
December 4, 2024 16:35
Destroyed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://funidata.atlassian.net/browse/DS-397
aria-level
value of 2 and variant of 'lg', but since we want to make sure that developers take into consideration the semantic order, following changes have been made:level
as required propertylevel
andtitleVariant
default valuestitleVariant
logic to match the correspondinglevel
which can be overridentitle
andlevel
as required propertiestitleVariant
default value and adjust its logic to match the correspondinglevel
which can be overriden