Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Section, Form]: Remove default level and titleVariant values, make title and level as required properties #496

Merged
merged 18 commits into from
Dec 4, 2024

Conversation

RiinaKuu
Copy link
Contributor

@RiinaKuu RiinaKuu commented Nov 28, 2024

https://funidata.atlassian.net/browse/DS-397

  1. Section is part of the semantic order of the page. Initially Section title had a default aria-level value of 2 and variant of 'lg', but since we want to make sure that developers take into consideration the semantic order, following changes have been made:
  • Set level as required property
  • Removed level and titleVariant default values
  • Adjust titleVariant logic to match the corresponding level which can be overriden
  1. Same kind of changes in Form Component as well
  • Set title and level as required properties
  • Removed titleVariant default value and adjust its logic to match the corresponding level which can be overriden
  1. Updated docs and created Typography util function which is used in Heading and Section components.

@RiinaKuu RiinaKuu added the breaking change This change is not backwards-compatible label Nov 28, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level November 28, 2024 15:01 Destroyed
… remove titleVariant default value and add logic to it
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level November 29, 2024 13:37 Destroyed
@RiinaKuu RiinaKuu changed the title [Section]: Remove default level and titleVariant values [Section, Form]: Remove default level and titleVariant values, make title and level as required properties Nov 29, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level November 29, 2024 16:00 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level November 29, 2024 16:03 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level December 2, 2024 12:46 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level December 2, 2024 13:18 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level December 3, 2024 07:41 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level December 3, 2024 07:49 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level December 3, 2024 08:50 Destroyed
Copy link
Contributor

@videoeero videoeero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level December 3, 2024 11:53 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-397-section-remove-default-level December 4, 2024 16:35 Destroyed
@videoeero videoeero merged commit 051f5d2 into main Dec 4, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@videoeero videoeero deleted the DS-397-section-remove-default-level branch December 4, 2024 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants