Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Error Summary Service]: Add and Remove Errors to public API #489

Merged
merged 30 commits into from
Nov 22, 2024
Merged

[Error Summary Service]: Add and Remove Errors to public API #489

merged 30 commits into from
Nov 22, 2024

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Nov 19, 2024 •
edited
Loading

  • Added two new public methods to Error Summary Service: addError and removeError
  • Renamed internally used functions
  • Simplified Error Summary types and various functions
  • Added transloco to Storybook
  • Updated tests

@videoeero videoeero added the improvement Improve or extend something that already exists label Nov 19, 2024
@videoeero videoeero marked this pull request as draft November 19, 2024 10:00
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 19, 2024 10:12 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 19, 2024 13:45 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 20, 2024 07:42 Destroyed
@videoeero videoeero marked this pull request as ready for review November 20, 2024 12:02
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 20, 2024 20:16 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 20, 2024 20:17 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 21, 2024 08:06 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 21, 2024 19:46 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 21, 2024 19:59 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 21, 2024 19:59 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 21, 2024 20:42 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 22, 2024 09:50 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 22, 2024 12:28 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 22, 2024 12:41 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 22, 2024 12:42 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 22, 2024 14:32 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-391-error-summary-public-api-part-3 November 22, 2024 15:10 Destroyed
@RiinaKuu RiinaKuu merged commit 0753f09 into main Nov 22, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-391-error-summary-public-api-part-3 branch November 22, 2024 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RiinaKuu RiinaKuu RiinaKuu approved these changes

Assignees
No one assigned
Labels
improvement Improve or extend something that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@videoeero @RiinaKuu