[Datepicker, Tooltip]: Angular Material based components not reflecting all styles correctly in customer app #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… certain typography in order to reflect them in customer app side as well.
github-actions
bot
temporarily deployed
to
Documentation for branch DS-355-ngmaterial-component-style-fixes
github-actions
bot
temporarily deployed
to
Documentation for branch DS-355-ngmaterial-component-style-fixes
github-actions
bot
temporarily deployed
to
Documentation for branch DS-355-ngmaterial-component-style-fixes
videoeero
approved these changes
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://funidata.atlassian.net/browse/DS-355
Certain typography styles did not reflect correctly in customer (Sisu) application side. This might be due to Material 3 update where most of the typography configs were removed and M3 did not have clear instructions how to set up custom typography for individual components.
To fix the issue, some typography styles are overwritten in Datepicker and Tooltip components' respective
ngMaterial-theme.scssfiles. These changes should not effect the components in any way in Fudis.