-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Select, Multiselect]: New input properties 'autocompleteFilter' and 'autocompleteNoResultsText' with Storybook examples #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 22, 2024 10:15
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 22, 2024 15:52
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 23, 2024 06:34
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 23, 2024 09:06
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 23, 2024 09:07
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 23, 2024 10:15
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 23, 2024 10:16
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 23, 2024 11:34
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 23, 2024 13:57
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 24, 2024 07:39
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 24, 2024 09:10
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 24, 2024 10:33
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 25, 2024 08:31
Destroyed
RiinaKuu
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 28, 2024 08:08
Destroyed
github-actions
bot
temporarily deployed
to
Documentation for branch DS-344-select-search-impr
October 28, 2024 09:35
Destroyed
RiinaKuu
approved these changes
Oct 28, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://funidata.atlassian.net/browse/DS-344
Fudis application has a need that Select Autocomplete variants selectable options are not loaded instantly in HTML, but only after user input has been evaluated and filtered matching options from the backend. This PR adds support for this, as new prop can disable default autocomplete filtering logic and give application more freedom on this. Also "No results found" default text can be set by application to for example "Searching results..." while backend search is in progress.
Also updated tests, docs and added Storybook examples.