Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select, Multiselect]: New input properties 'autocompleteFilter' and 'autocompleteNoResultsText' with Storybook examples #470

Merged
merged 29 commits into from
Oct 28, 2024

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Oct 22, 2024

Jira ticket: https://funidata.atlassian.net/browse/DS-344

Fudis application has a need that Select Autocomplete variants selectable options are not loaded instantly in HTML, but only after user input has been evaluated and filtered matching options from the backend. This PR adds support for this, as new prop can disable default autocomplete filtering logic and give application more freedom on this. Also "No results found" default text can be set by application to for example "Searching results..." while backend search is in progress.

Also updated tests, docs and added Storybook examples.

@videoeero videoeero added the improvement Improve or extend something that already exists label Oct 22, 2024
@videoeero videoeero marked this pull request as draft October 22, 2024 10:13
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 22, 2024 10:15 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 22, 2024 15:52 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 23, 2024 06:34 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 23, 2024 09:06 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 23, 2024 09:07 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 23, 2024 10:15 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 23, 2024 10:16 Destroyed
@videoeero videoeero marked this pull request as ready for review October 23, 2024 10:48
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 23, 2024 11:34 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 23, 2024 13:57 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 24, 2024 07:39 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 24, 2024 09:10 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 24, 2024 10:33 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 25, 2024 08:31 Destroyed
Copy link
Contributor

@RiinaKuu RiinaKuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When selecting one item from the list, blurring and focusing to the input again, dropdown opens but it shows the first option of the whole data and not the selected one:

Screenshot 2024-10-25 at 11 52 12

@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 28, 2024 08:08 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-344-select-search-impr October 28, 2024 09:35 Destroyed
@RiinaKuu RiinaKuu merged commit c55a82a into main Oct 28, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-344-select-search-impr branch October 28, 2024 11:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improve or extend something that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants