[AlertGroup]: Missing documentation about template usage #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
Documentation for branch DS-355-update-alert-docs
videoeero
reviewed
Oct 21, 2024
| @@ -9,6 +9,12 @@ import { AlertGroupComponent } from "./alert-group/alert-group.component.ts"; | |||
|
|
|||
| Alert Group Component displays list of toaster-like Alert Components with four variants: `success`, `info`, `warning` and `danger.` These variants are the same ones as with [Notification Component](/docs/components-notification--documentation). | |||
|
|
|||
| ## Usage Guidelines | |||
|
|
|||
| First, add `<fudis-alert-group />` HTML tag in the application template, preferably somewhere up in the application's DOM, e.g. `app.component.html`. | |||
There was a problem hiding this comment.
For the DOM structure we should probably instruct to put component as the "bottom element" of app.component.html etc. as that will make it more likely, that it will appear as the top element, even top of Navigation. This probably should be fixed in our examples and in our Dialog component as well, that Alert Group is last and not first element in DOM.
…n Dialog component and Sandbox
github-actions
bot
temporarily deployed
to
Documentation for branch DS-355-update-alert-docs
videoeero
approved these changes
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://funidata.atlassian.net/browse/DS-355
<fudis-alert-group />in the application template.