Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Footer]: Fix focus area #461

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[Footer]: Fix focus area #461

merged 5 commits into from
Oct 10, 2024

Conversation

RiinaKuu
Copy link
Contributor

@RiinaKuu RiinaKuu commented Oct 9, 2024

https://funidata.atlassian.net/browse/DS-354

Links had unnecessary big focus area inside Footer
--> removed min-height from the links and adjusted margins

@RiinaKuu RiinaKuu added the bug fix Something isn't working as expected label Oct 9, 2024
@RiinaKuu RiinaKuu changed the title [Footer]: Fix focus styles [Footer]: Fix focus area Oct 9, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-footer-fix October 10, 2024 06:26 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-footer-fix October 10, 2024 07:10 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-354-footer-fix October 10, 2024 07:20 Destroyed
Copy link
Contributor

@videoeero videoeero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@videoeero videoeero merged commit f5cfc5a into main Oct 10, 2024
10 checks passed
@videoeero videoeero deleted the DS-354-footer-fix branch October 10, 2024 09:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants