[Form Common API]: Remove disabled & invalidState properties #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MayaMarjut
previously approved these changes
Sep 30, 2024
github-actions
bot
temporarily deployed
to
Documentation for branch DS-296-remove-disabled-input
github-actions
bot
temporarily deployed
to
Documentation for branch DS-296-remove-disabled-input
github-actions
bot
temporarily deployed
to
Documentation for branch DS-296-remove-disabled-input
github-actions
bot
temporarily deployed
to
Documentation for branch DS-296-remove-disabled-input
MayaMarjut
reviewed
Sep 30, 2024
...s/ngx-fudis/src/lib/components/form/localized-text-group/localized-text-group.component.html
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
Documentation for branch DS-296-remove-disabled-input
MayaMarjut
approved these changes
Sep 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira-ticket: https://funidata.atlassian.net/browse/DS-296
BREAKING CHANGE:
disabledandinvalidStateproperties are removed. Disabling should be done straight from FormControl. InvalidState was previously used internally, but is no longer needed and form field's invalid state should come from FormControl as well.IMPROVEMENT LocalizedTextGroup