Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RadioButton, Checkbox]: Unify output namings, refactor radio button and checkbox blur and change events #445

Merged
merged 11 commits into from
Sep 28, 2024
Merged

[RadioButton, Checkbox]: Unify output namings, refactor radio button and checkbox blur and change events #445

merged 11 commits into from
Sep 28, 2024

Conversation

xanxan
Copy link
Contributor

@xanxan xanxan commented Sep 24, 2024

https://funidata.atlassian.net/browse/DS-372

BREAKING CHANGE

  • Unify output names to use handle prefix
  • Remove radioButtonBlur output from RadioButton component, call parent onBlur instead
  • Add handleChange output for RadioButton component
  • On Checkbox Component, add input blur to call also parent onBlur

@xanxan xanxan added the breaking change This change is not backwards-compatible label Sep 24, 2024
@xanxan xanxan changed the title [BreakingChange]: Unify output namings, refactor radio button and checkbox blur and change events [RadioButton][Checkbox][Autocomplete]: Unify output namings, refactor radio button and checkbox blur and change events Sep 26, 2024
@videoeero videoeero changed the title [RadioButton][Checkbox][Autocomplete]: Unify output namings, refactor radio button and checkbox blur and change events [RadioButton, Checkbox]: Unify output namings, refactor radio button and checkbox blur and change events Sep 26, 2024
@videoeero videoeero changed the title [RadioButton, Checkbox]: Unify output namings, refactor radio button and checkbox blur and change events [RadioButton, Checkbox, Select Autocomplete]: Unify output namings, refactor radio button and checkbox blur and change events Sep 26, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 27, 2024 07:47 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 27, 2024 07:48 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 27, 2024 08:55 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 27, 2024 09:03 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 27, 2024 09:04 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 27, 2024 11:52 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 28, 2024 07:57 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 28, 2024 08:05 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-372 September 28, 2024 09:28 Destroyed
@videoeero videoeero changed the title [RadioButton, Checkbox, Select Autocomplete]: Unify output namings, refactor radio button and checkbox blur and change events [RadioButton, Checkbox]: Unify output namings, refactor radio button and checkbox blur and change events Sep 28, 2024
@videoeero videoeero merged commit 497c9f8 into main Sep 28, 2024
10 checks passed
@videoeero videoeero deleted the DS-372 branch September 28, 2024 10:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@videoeero videoeero videoeero approved these changes

Assignees
No one assigned
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xanxan @videoeero