Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid, Section, DL]: Remove marginTop and marginBottom input properties from Grid, change classes input to type from array to string #440

Merged
merged 15 commits into from
Sep 30, 2024
Merged

[Grid, Section, DL]: Remove marginTop and marginBottom input properties from Grid, change classes input to type from array to string #440

merged 15 commits into from
Sep 30, 2024

Conversation

xanxan
Copy link
Contributor

@xanxan xanxan commented Sep 18, 2024 •
edited by videoeero
Loading

https://funidata.atlassian.net/browse/DS-368

BREAKING CHANGE GRID:

  • Remove marginTop and marginBottom input properties
  • Change classes type from string[] to string
  • Remove references from tests, documentation and stories
  • Replace usages with fudis spacing classes
  • Refactor Grid directive to inherit classes given through the class property, so the spacing classes can be applied

BREAKING CHANGE SECTION & DL

  • Change classes type from string[] to string

BEAKING CHANGE SPACING TOKENS

  • Renamed form field related "spacing" SCSS tokens to better describe their purpose.

@xanxan xanxan added the breaking change This change is not backwards-compatible label Sep 18, 2024
@xanxan xanxan changed the title [BREAKING CHANGE][Grid]: Remove marginTop and marginBottom input properties from Grid, replace usages with fudis spacing classes [Breaking change][Grid]: Remove marginTop and marginBottom input properties from Grid, replace usages with fudis spacing classes Sep 18, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 19, 2024 13:00 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 19, 2024 13:01 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 19, 2024 15:00 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 20, 2024 07:55 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 21, 2024 19:52 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 22, 2024 20:15 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 23, 2024 11:57 Destroyed
@RiinaKuu
DS-368: Remove default fudis-my-none class from Description List, ove…
c19e37f 
…rwrite browser margins in component styles, add docs, fix one remaining marginTop attribute
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 23, 2024 13:15 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 24, 2024 06:30 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 24, 2024 09:27 Destroyed
@xanxan xanxan changed the title [Breaking change][Grid]: Remove marginTop and marginBottom input properties from Grid, replace usages with fudis spacing classes [Grid]: Remove marginTop and marginBottom input properties from Grid, replace usages with fudis spacing classes Sep 26, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 27, 2024 11:51 Destroyed
@xanxan
DS-368: Fix dialog heading bottom margin to be xs so it equals to bot…
e015706 
…tom margin value in Figma, updates snapshots
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 27, 2024 12:39 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 27, 2024 14:20 Destroyed
@videoeero videoeero changed the title [Grid]: Remove marginTop and marginBottom input properties from Grid, replace usages with fudis spacing classes [Grid, Section, DL]: Remove marginTop and marginBottom input properties from Grid, change classes input to type from array to string Sep 27, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 28, 2024 09:39 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch DS-368 September 28, 2024 10:10 Destroyed
@RiinaKuu RiinaKuu merged commit 1d055e5 into main Sep 30, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the DS-368 branch September 30, 2024 06:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RiinaKuu RiinaKuu RiinaKuu approved these changes

@videoeero videoeero videoeero approved these changes

Assignees
No one assigned
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xanxan @videoeero @RiinaKuu