Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guidance, Description-List, Button, Notification]: Fix max-length indiactor's width and spacing, Hide variant option from Nested DL-Story, Adjust Button Height, Adjust Notification width and internal button styling #394

Merged
merged 15 commits into from
Jun 25, 2024
Merged

[Guidance, Description-List, Button, Notification]: Fix max-length indiactor's width and spacing, Hide variant option from Nested DL-Story, Adjust Button Height, Adjust Notification width and internal button styling #394

merged 15 commits into from
Jun 25, 2024

Conversation

xanxan
Copy link
Contributor

@xanxan xanxan commented Jun 20, 2024 •
edited
Loading

Jira-ticket: https://funidata.atlassian.net/browse/DS-330

  • Guidance: Max-length indiactor width changes along the used character length, which can make dispalying the guidance text buggy. Fixed the indicator space to have standard width with inner left spacing, depending of the size of the digits.
  • Description List: On Storybook, hide variant toggle from the nested description list story
  • Button: Fix button heigths so that the longer button text fits inside button when setting for two lines
  • Notification: Set maximum width to be LG (960px); Style Buttons inside Notification to look like a Link

@xanxan xanxan added the bug fix Something isn't working as expected label Jun 20, 2024
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 20, 2024 10:43 Destroyed
videoeero
videoeero reviewed Jun 20, 2024
View reviewed changes
ngx-fudis/projects/ngx-fudis/src/lib/components/form/guidance/guidance.component.ts
@@ -121,6 +126,7 @@ export class GuidanceComponent implements OnInit {

ngOnInit(): void {
if (this.maxLength) {
this._maxLengthWidth = this.maxLength > 100 ? 'lg' : this.maxLength > 10 ? 'md' : 'sm';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be refactored away from ngOnInit to ngOnChanges, so if for some reason maxLength value changes the values must be calculated again.

@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 20, 2024 13:19 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 20, 2024 13:57 Destroyed
@xanxan xanxan changed the title [Guidance]: Fix max-length indiactor's width and spacing [Guidance, Description-List]: Fix max-length indiactor's width and spacing, Hide variant option from Nested DL-Story Jun 20, 2024
@xanxan xanxan force-pushed the fudis-paivystysvuoro-231-korjaukset branch from 14731fa to cbfa6e4 Compare June 20, 2024 15:25
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 20, 2024 15:26 Destroyed
@xanxan xanxan changed the title [Guidance, Description-List]: Fix max-length indiactor's width and spacing, Hide variant option from Nested DL-Story [Guidance, Description-List, Button]: Fix max-length indiactor's width and spacing, Hide variant option from Nested DL-Story, Adjust Button Height Jun 20, 2024
@xanxan xanxan force-pushed the fudis-paivystysvuoro-231-korjaukset branch from cbfa6e4 to edf2508 Compare June 20, 2024 19:10
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 20, 2024 19:10 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 20, 2024 19:14 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 23, 2024 21:43 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 24, 2024 07:42 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 24, 2024 08:48 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 24, 2024 08:57 Destroyed
RiinaKuu
RiinaKuu previously approved these changes Jun 24, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 24, 2024 13:35 Destroyed
@github-actions github-actions bot temporarily deployed to Documentation for branch fudis-paivystysvuoro-231-korjaukset June 24, 2024 16:48 Destroyed
@RiinaKuu RiinaKuu merged commit 410910e into main Jun 25, 2024
10 checks passed
@RiinaKuu RiinaKuu deleted the fudis-paivystysvuoro-231-korjaukset branch June 25, 2024 05:55
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
@xanxan xanxan changed the title [Guidance, Description-List, Button]: Fix max-length indiactor's width and spacing, Hide variant option from Nested DL-Story, Adjust Button Height [Guidance, Description-List, Button, Notification]: Fix max-length indiactor's width and spacing, Hide variant option from Nested DL-Story, Adjust Button Height, Adjust Notification width and internal button styling Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@videoeero videoeero videoeero left review comments

@RiinaKuu RiinaKuu RiinaKuu approved these changes

Assignees
No one assigned
Labels
bug fix Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xanxan @videoeero @RiinaKuu