-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grid, GridItem, GridService]: Check & refactoring for 1.0 #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
videoeero
added
the
exclude from release notes
This PR will not be included in the release notes
label
Feb 22, 2024
github-actions
bot
requested a deployment
to
docs-DS-252-grid-check
February 22, 2024 16:02
Abandoned
videoeero
added
breaking change
This change is not backwards-compatible
and removed
exclude from release notes
This PR will not be included in the release notes
labels
Feb 23, 2024
videoeero
changed the title
[GridDirective]: Check & refactoring for 1.0
[Grid, GridItem, GridService]: Check & refactoring for 1.0
Feb 23, 2024
github-actions
bot
requested a deployment
to
docs-DS-252-grid-check
February 28, 2024 12:36
Abandoned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking renaming:
alignX
-->alignSelfX
alignY
-->alignSelfY
ignoreDefaults
(default value previouslyfalse
) -->serviceDefaults
(default value nowtrue
)marginSides
propertyalign
property should be used insteadalign
property default to 'start'setGridDefaultValues
-->setDefaultValues
getGridDefaultValues
-->getDefaultValues
Fix also RadioButtonGroup name bug
Adjusted Tooltip Storybook docs
Add default margin-bottom for Breadcrumbs. This was discussed with designers.
Removed white-space: prewrap attributes from DL