Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid, GridItem, GridService]: Check & refactoring for 1.0 #295

Merged
merged 53 commits into from
Mar 1, 2024

Conversation

videoeero
Copy link
Contributor

@videoeero videoeero commented Feb 22, 2024

Breaking renaming:

  • GridItem: alignX --> alignSelfX
  • GridItem: alignY --> alignSelfY
  • Grid: ignoreDefaults (default value previously false) --> serviceDefaults (default value now true)
  • Grid: Removed marginSides property
    • align property should be used instead
    • Changed align property default to 'start'
  • FudisGridServices
    • setGridDefaultValues --> setDefaultValues
    • getGridDefaultValues --> getDefaultValues

Fix also RadioButtonGroup name bug
Adjusted Tooltip Storybook docs
Add default margin-bottom for Breadcrumbs. This was discussed with designers.
Removed white-space: prewrap attributes from DL

@videoeero videoeero added the exclude from release notes This PR will not be included in the release notes label Feb 22, 2024
@github-actions github-actions bot requested a deployment to docs-DS-252-grid-check February 22, 2024 16:02 Abandoned
@videoeero videoeero marked this pull request as draft February 22, 2024 16:02
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 22, 2024 16:22 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 23, 2024 12:22 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 23, 2024 13:06 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 23, 2024 14:01 Inactive
@videoeero videoeero added breaking change This change is not backwards-compatible and removed exclude from release notes This PR will not be included in the release notes labels Feb 23, 2024
@videoeero videoeero changed the title [GridDirective]: Check & refactoring for 1.0 [Grid, GridItem, GridService]: Check & refactoring for 1.0 Feb 23, 2024
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 27, 2024 15:25 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 27, 2024 15:28 Inactive
@github-actions github-actions bot requested a deployment to docs-DS-252-grid-check February 28, 2024 12:36 Abandoned
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 28, 2024 12:36 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 28, 2024 12:54 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 28, 2024 13:02 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 29, 2024 15:50 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 29, 2024 17:03 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 29, 2024 17:06 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 29, 2024 17:15 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check February 29, 2024 17:47 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check March 1, 2024 09:37 Inactive
@github-actions github-actions bot temporarily deployed to docs-DS-252-grid-check March 1, 2024 09:44 Inactive
@RiinaKuu RiinaKuu merged commit 65df917 into main Mar 1, 2024
12 checks passed
@RiinaKuu RiinaKuu deleted the DS-252-grid-check branch March 1, 2024 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change is not backwards-compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants