[Storybook]: Configuring ArgTypes filtering #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
docs-DS-240-link-and-notification-check
videoeero
added
exclude from release notes
github-actions
bot
temporarily deployed
to
docs-DS-240-link-and-notification-check
…der to get build through
…hese in its own PR
RiinaKuu
reviewed
Feb 16, 2024
|
|
||
| /** | ||
| * Link color | ||
| */ | ||
| @Input() color: 'primary-dark' | 'default' | 'white' = 'primary-dark'; | ||
| @Input() color: 'default' | 'gray' | 'white' = 'default'; |
There was a problem hiding this comment.
These color names originate from icon.component.scss and this "breaks" external link (at least). I agree these are not intuitive names but let's do the name refactoring in a separate PR. I added a TODO comment for the class names and reverted your changes regarding on these.
|
|
||
| export default { | ||
| title: 'Components/Button', | ||
| component: ButtonComponent, | ||
| parameters: { | ||
| docs: { | ||
| argTypes: { | ||
| exclude: buttonExclude, |
There was a problem hiding this comment.
For some reason (similar to Dialog) this didn't work and readme ArgTypes needed the exclude. So I deleted this one and added the exclude in readme.
…om/funidata/fudis into DS-240-link-and-notification-check
github-actions
bot
temporarily deployed
to
docs-DS-240-link-and-notification-check
RiinaKuu
added
exclude from release notes
github-actions
bot
temporarily deployed
to
docs-DS-240-link-and-notification-check
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING:
externalLinkInput renamed toexternal