[Rem converter]: Support for different base font-sizes #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
docs-DS-212-Foundations-tuki-rem-arvoille
MayaMarjut
changed the title
MayaMarjut
changed the title
MayaMarjut
changed the title
videoeero
changed the title
videoeero
reviewed
Oct 10, 2023
|
|
||
| ##### Define Primary Colors as CSS Variables in Project Root Style |
videoeero
reviewed
Oct 10, 2023
| @@ -72,6 +73,27 @@ import { NgxFudisModule } from 'ngx-fudis'; | |||
| --fudis-color-primary-extra-dark: #hex; | |||
| } | |||
| ``` | |||
| ##### Define Application's REM base CSS Variables in Project Root Style | |||
There was a problem hiding this comment.
--> Set Rem Base Value
github-actions
bot
temporarily deployed
to
docs-DS-212-Foundations-tuki-rem-arvoille
github-actions
bot
temporarily deployed
to
docs-DS-212-Foundations-tuki-rem-arvoille
github-actions
bot
temporarily deployed
to
docs-DS-212-Foundations-tuki-rem-arvoille
github-actions
bot
temporarily deployed
to
docs-DS-212-Foundations-tuki-rem-arvoille
github-actions
bot
temporarily deployed
to
docs-DS-212-Foundations-tuki-rem-arvoille
RiinaKuu
approved these changes
Oct 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.funidata.fi/browse/DS-212
Created a new CSS variable fudis-rem-multiplier and a new utility function convertToRemValue, which converts given rem numbers and returns value as a string with 'rem' abbreviation.
Fudis-rem-multiplier is used for changing values if needed from Fudis 16px based system to another REM base system.
Changing REM base requires now that fudis-rem-multiplier- and application font-size is changed in project root styles. Documentation was updated concerning the project setup.
A button was added to Application sandbox, for testing rem base change between 16px -> 10px base.
For testing fudis-rem-multiplier in Karma, karma.style.css file was configured to support 10px base REM values.
All hard coded rem values where checked in project and divided with a new fudis-rem-multiplier.