Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed commented out code #6

Merged
merged 1 commit into from
Apr 6, 2020
Merged

Conversation

credfeto
Copy link
Member

@credfeto credfeto commented Apr 6, 2020

PR Details

Description

Related Issue\Feature

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • There are no Resharper\static code analysis errors anywhere in the solution.
  • I have run a code clean-up on any files I have modified to make sure they are in the correct format.
  • I have added tests to cover my changes.
  • I have run the code and quickly verified it all works to my satisfaction.
  • All new/modified code has sufficient logging to be able to diagnose what is wrong.
  • All new and existing tests passed.
  • All new/modified public interfaces/classes have are documented with xmldoc comments.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.

@credfeto credfeto requested a review from a team as a code owner April 6, 2020 23:22
@github-actions github-actions bot added the C# C# Source Files label Apr 6, 2020
@credfeto
Copy link
Member Author

credfeto commented Apr 6, 2020

/rebase

@github-actions github-actions bot force-pushed the feature/octopus-notifications branch from 1af19b7 to 6172c14 Compare April 6, 2020 23:23
@credfeto credfeto merged commit 6cff174 into master Apr 6, 2020
@credfeto credfeto deleted the feature/octopus-notifications branch April 6, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# C# Source Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant