Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF-2488] - Feature/2488 net core update #21

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Conversation

nukec
Copy link
Contributor

@nukec nukec commented Jun 18, 2020

Description

net core update

Related Issue\Feature

https://funfairtech.atlassian.net/browse/FF-2488

How Has This Been Tested

  • All unit tests pass.
  • All integration tests pass.
  • Manual Testing:

Types of changes

  • Docs change
  • Refactoring
  • Dependency upgrade
  • Additional Unit Tests\Integration Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Deployment Configuration Changes

  • Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

  • There are no Resharper\static code analysis errors anywhere in the solution.
  • I have run a code clean-up on any files I have modified to make sure they are in the correct format.
  • I have added tests to cover my changes.
  • I have run the code and quickly verified it all works to my satisfaction.
  • All new/modified code has sufficient logging to be able to diagnose what is wrong.
  • All new and existing tests passed.
  • All new/modified public interfaces/classes have are documented with xmldoc comments.
  • Unreleased section of CHANGELOG.md has been updated with details of this PR.

@nukec nukec requested a review from a team as a code owner June 18, 2020 17:52
@github-actions github-actions bot added C# C# Source Files Change Log Changelog tracking file labels Jun 18, 2020
credfeto
credfeto previously approved these changes Jun 18, 2020
@credfeto
Copy link
Member

/rebase

@nukec nukec merged commit 650ebf6 into master Jun 19, 2020
@nukec nukec deleted the feature/2488-net-core-update branch June 19, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# C# Source Files Change Log Changelog tracking file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants