-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gas weight conversion for N2O to N and fix weight conversion for SC-SF6 #68
Conversation
@davidanthoff I also just noticed in the documentation that the units for SF6 emissions in FUND are "million metric tonnes of carbon dioxide equivalent." Does that mean that in order to report the SC-SF6 in units of dollars per ton of SF6, we would actually need to multiple by some GWP? (i.e., is the compute_sf6 function currently returning the value in $/ton of CO2e?) |
@davidanthoff to revisit ASAP For N2O we have this change already in version 3.8.6 used for IWG, so I'm confident we should change it here ... and I also checked with the below units validation. We connect our marginal pulse into the global check
USA check
For SF6 I don't think we're using CO2 eq given the conversion is 1:22,600, but the comments do say that SF6 is kt not Mt ... and given this which puts us 8,100 tons in 2020 this acutally seems about right ... so we are off by a factor of 1000. This is corroborated by:
we removed SF6 from version 3.8.6 for clarity |
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 79.10% 79.28% +0.18%
==========================================
Files 39 39
Lines 938 956 +18
==========================================
+ Hits 742 758 +16
- Misses 196 198 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
use these to gut-check from |
I think that computing the social cost of N2O was previously returning the social cost per ton of N not N2O, because the units in the emissions component are in tons of N. This PR normalizes the pulse size to be in tons of N2O instead