Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the following, which is my interpretation of the two use cases of the
nsteps
option toget_model
:nsteps
option just to shorten the time dimension, still using all the default FUND parameter values, then we need to wait to reset the time dimension until after callingset_leftover_params!
, since this currently produces an error from Mimi since the default parameter values are longer than the requested time dimension.nsteps
to be longer than thedefault_nsteps
, then they need to provide an alternativedatadir
orparams
dictionary with values that will work for that length of time dimension. In this case, we set the new time dimension before setting the parameter values.